Skip to content

CI: give each runner its own pnpm install dir - #1765

Closed
joepio wants to merge 4 commits into
developfrom
claude/project-thread-8tdupo
Closed

joepio wants to merge 4 commits into
developfrom
claude/project-thread-8tdupo

Conversation

@joepio

@joepio joepio commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Requested by Joep · project thread

Before: pnpm installs into ~/setup-pnpm, and every runner on the same host shares that directory. On 2026-09-25, develop run 4596 failed at "Install pnpm" with ENOTEMPTY because another runner's job was installing there at the same second.

After: each job installs pnpm into its own runner's temp directory, so two runners on one host no longer collide.

How: sets dest: ${{ runner.temp }}/setup-pnpm on the two pnpm steps that run on Mancave: the ci job in main-ci.yml and the Downstream job in main.yml. This PR originally also removed the staging dispatch and added the 150-minute CI timeout. Both of those landed in TrekMeester batch #1773, and develop has been merged into this branch, so only the pnpm change is left.

atomic-saas deploys staging only when started by hand since its PR 148,
so deploy_staging.yml no longer listens for the atomic-server-develop
event and this workflow's dispatch reached nothing. To test an
atomic-server branch there, start Deploy to staging in atomic-saas with
atomic_server_ref set to it. ATOMIC_SAAS_DISPATCH_TOKEN stays: main.yml's
Downstream job still uses it to read atomic-saas.
The ci job had no timeout-minutes, so GitHub's 6-hour default applied.
On 2026-09-25 both Mancave CI jobs (develop run 4587 and batch run
4591) stopped logging at the same minute, mid e2e, and would hold both
runners until that default released them. A full run takes 45 to 75
minutes; 150 leaves room for a cold per-runner cache. The images job
already has 120.
@joepio joepio changed the title Stop dispatching atomic-saas staging deploys on every develop push CI: drop the staging dispatch, and time out a stuck CI job Sep 25, 2026
joepio added a commit that referenced this pull request Sep 25, 2026
pnpm/action-setup defaults to ~/setup-pnpm, which every runner on a host
shares. On 2026-09-25 develop run 4596 failed at Install pnpm with
ENOTEMPTY because the batch's Downstream job on the other Mancave runner
was installing into the same directory at the same second. Point dest at
runner.temp in the two jobs that run on Mancave.
@joepio joepio changed the title CI: drop the staging dispatch, and time out a stuck CI job CI: drop the staging dispatch, time out a stuck CI job, give each runner its own pnpm Sep 25, 2026
@joepio

joepio commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

Landed on develop as part of the TrekMeester batch #1773 (squash commit 1d7f312), after a green Main pipeline run on the combined branch.

@joepio joepio closed this Sep 25, 2026
@joepio joepio reopened this Sep 25, 2026

joepio commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

Reopened. Batch #1773 carried this PR at 467f182, so the staging-dispatch removal and the CI timeout are on develop. The last commit, f7b03bd ("give each runner its own pnpm"), is not. It goes into the next TrekMeester batch.


Generated by Claude Code

@gitguardian

gitguardian Bot commented Sep 25, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
37585749 Triggered Generic Password cb4cc98 lib/src/vault/secret_envelope.rs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@joepio joepio changed the title CI: drop the staging dispatch, time out a stuck CI job, give each runner its own pnpm CI: give each runner its own pnpm install dir Sep 25, 2026

joepio commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

The red GitGuardian check is not from this PR's change. It flags lib/src/vault/secret_envelope.rs:537, which reached this branch through the merge of develop (it came in with batch #1773). That line is a test listing the names of old wrapper kinds ("recovery-code", "password", "webauthn-prf"), so the detector is matching the word "password". There is no credential there. The comment right above it already says the values are placeholder bytes. This PR only touches the two workflow files. The incident needs to be marked as a false positive in the GitGuardian dashboard, which I don't have access to. There's nothing to re-run.


Generated by Claude Code

joepio added a commit that referenced this pull request Sep 25, 2026
…) (#1828)

Combined batch, green on Mancave in run 4639 on 3be85ae.

Includes #1809, #1810, #1811, #1812, #1813, #1814, #1815, #1816, #1817,
#1818, #1819, #1820, #1821, #1823, #1824, #1827 and #1765, plus the e2e
label updates for #1816 and settled translation catalogs.

joepio commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

Landed on develop in 46562ff via the combined batch #1828 (green on Mancave, run 4639). Closing.


Generated by Claude Code

@joepio joepio closed this Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant